Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve PyPDFToDocument #7361

Closed
anakin87 opened this issue Mar 14, 2024 · 0 comments · Fixed by #7362
Closed

Improve PyPDFToDocument #7361

anakin87 opened this issue Mar 14, 2024 · 0 comments · Fixed by #7362
Assignees

Comments

@anakin87
Copy link
Member

Currently this component is not very flexible or easy to customize.

In the past, we tried to make this component more flexible in #6258, introducing the possibility to pass custom PyPDFConverters.
Then we had issues with serialization (#6388) and solved the problem by temporarily introducing a registry (#6396).

This makes it difficult for users to introduce custom PyPDFConverters (somewhat related: #6896).

As discussed with Silvano, now that proper type serialization is in place, we would like to

  • get rid of the registry
  • introduce to_dict/from_dict in the PyPDFConverter protocol
  • incorporate these changes into the Default Converter, which can also be a good example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant