Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: MetaFieldRanker - make weight passed in run to be used even if 0 #7343

Merged
merged 1 commit into from
Mar 11, 2024
Merged

fix: MetaFieldRanker - make weight passed in run to be used even if 0 #7343

merged 1 commit into from
Mar 11, 2024

Conversation

anakin87
Copy link
Member

Related Issues

Proposed Changes:

Simply check if weight is not null

How did you test it?

CI. Manual test.

Checklist

@anakin87 anakin87 requested review from a team as code owners March 11, 2024 11:26
@anakin87 anakin87 requested review from dfokina and vblagoje and removed request for a team March 11, 2024 11:26
@github-actions github-actions bot added the 2.x Related to Haystack v2.0 label Mar 11, 2024
vblagoje
vblagoje approved these changes Mar 11, 2024
View reviewed changes
Copy link
Member

@vblagoje vblagoje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 8232004499

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.043%
Totals Coverage Status
Change from base Build 8231547065: 0.0%
Covered Lines: 5290
Relevant Lines: 5875
💛 - Coveralls

@anakin87 anakin87 merged commit f8b9f71 into main Mar 11, 2024
24 checks passed
@anakin87 anakin87 deleted the fix-metafieldranker-weight-in-run-method branch March 11, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vblagoje vblagoje vblagoje approved these changes

@dfokina dfokina Awaiting requested review from dfokina dfokina is a code owner automatically assigned from deepset-ai/documentation

Assignees
No one assigned
Labels
2.x Related to Haystack v2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

init param overrides run param for metafieldranker
3 participants
@anakin87 @coveralls @vblagoje