make weight defined in run to be used even if 0 (#7343)

deepset-ai · Mar 11, 2024 · f8b9f71 · f8b9f71
1 parent ad2366c
commit f8b9f71
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/haystack/components/rankers/meta_field.py b/haystack/components/rankers/meta_field.py
@@ -191,7 +191,7 @@ def run(
  return {"documents": []}
 
  top_k = top_k or self.top_k
- weight = weight or self.weight
+ weight = weight if weight is not None else self.weight
  ranking_mode = ranking_mode or self.ranking_mode
  sort_order = sort_order or self.sort_order
  meta_value_type = meta_value_type or self.meta_value_type

diff --git a/releasenotes/notes/fix-metafieldranker-weight-in-run-method-e4e11011a8b99c34.yaml b/releasenotes/notes/fix-metafieldranker-weight-in-run-method-e4e11011a8b99c34.yaml
@@ -0,0 +1,5 @@
+---
+fixes:
+ - |
+ Fixed a bug in the `MetaFieldRanker`: when the `weight` parameter was set to 0 in the `run` method,
+ the component was incorrectly using the default `weight` parameter set in the `__init__` method.