feat: added split by page to DocumentSplitter

[sahusiddharth]

• fixes feat: Add split by page to DocumentSplitter #6707

• The new split_by value, 'page', has been introduced in the DocumentSplitter to enable users to split documents based on the "\f" character, facilitating the preservation of context and allowing for more flexible chunking options.

[coveralls]

Pull Request Test Coverage Report for Build 7556521537

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.1%) to 88.015%

---

Totals
Change from base Build 7543114073:	0.1%
Covered Lines:	4531
Relevant Lines:	5148

---

💛 - Coveralls

[sjrl]

Thanks @sahusiddharth this is looking good! I left a few minor change suggestions.

Otherwise, it would be great if you could add a unit test for this new split_by option. So please make an similar test as this one

haystack/test/components/preprocessors/test_document_splitter.py

Line 83 in 7376838

def test_split_by_passage(self):

in that same file.

Then this PR should be good to go!

[sjrl]

Looking good! Almost there, could you also add this suggested change?

[sahusiddharth]

@sjrl, I'm sorry for wasting so much of your time. I didn't understood what needs to be done and was barking on the wrong tree.

[sjrl]

@sjrl, I'm sorry for wasting so much of your time. I didn't understood what needs to be done and was barking on the wrong tree.

Sorry, I didn't mean for it to come off that way! I just thought I could make a quick change to the PR to finish it up :)

[sahusiddharth]

@sjrl It is not your fault, it's just that it is a very small issue, I should have completed it in one go.

[sjrl]

No problem, we really appreciate the contribution!

[sjrl]

LGTM!