Use cache for hf requests during CI #2379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZanSara
approved these changes
Mar 31, 2022
test/test_faiss_and_milvus.py
Outdated
Comment on lines
509
to
510
| assert np.allclose(original_emb, result_emb, rtol=0.2) # high tolerance necessary for Milvus 2 | ||
| np.testing.assert_allclose( | ||
| original_emb, result_emb, rtol=0.2, atol=5e-07 | ||
| ) # high tolerance necessary for Milvus 2 |
There was a problem hiding this comment.
This change comes from the other PR, is it? #2375
There was a problem hiding this comment.
Yes, sorry for that! merging master into this branch should make it disappear.
tstadel
added
type:bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes HTTP 405 during CI
Proposed changes:
Status (please check what you already did):