Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Fix all_close comparison for milvus #2375

Merged
merged 1 commit into from
Mar 31, 2022
Merged

CI: Fix all_close comparison for milvus #2375

merged 1 commit into from
Mar 31, 2022

Conversation

tstadel
Copy link
Member

@tstadel tstadel commented Mar 30, 2022 •
edited
Loading

This fixes the CI randomly failing due to milvus imprecisions.

Proposed changes:

  • increase all_close absolute tolerance for milvus
  • use np.testing.assert_allclose to get better assertion infos

Status (please check what you already did):

  • First draft (up for discussions & feedback)
  • Final code

@tstadel tstadel requested a review from ZanSara March 30, 2022 16:40
ZanSara
ZanSara approved these changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@ZanSara ZanSara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙂

@ZanSara ZanSara mentioned this pull request Mar 31, 2022
Merged
2 tasks
@tstadel tstadel added type:bug Something isn't working ignore-for-release-notes PRs with this flag won't be included in the release notes. topic:document_store labels Mar 31, 2022
@tstadel tstadel merged commit 5b52690 into master Mar 31, 2022
@tstadel tstadel deleted the fix_milvus_allclose_ci branch March 31, 2022 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZanSara ZanSara ZanSara approved these changes

Assignees
No one assigned
Labels
ignore-for-release-notes PRs with this flag won't be included in the release notes. topic:document_store type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tstadel @ZanSara