Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable cache on the CI #2083

Merged
merged 20 commits into from
Jan 28, 2022
Merged

Disable cache on the CI #2083

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
b30f97f
Disable cache on the CI
ZanSara Jan 28, 2022
62e28e8
Almost disable cache
ZanSara Jan 28, 2022
f724b13
Reintroduce paths
ZanSara Jan 28, 2022
733cc0a
Reintroduce paths
ZanSara Jan 28, 2022
c252533
Typo
ZanSara Jan 28, 2022
beda3c3
Add most files to the cache key
ZanSara Jan 28, 2022
514c415
remove date and path from cache key
ZanSara Jan 28, 2022
63d9e62
Trying to tweak version import
ZanSara Jan 28, 2022
5c10baa
Revert
ZanSara Jan 28, 2022
359309f
Disable the cache entirely
ZanSara Jan 28, 2022
4fc5418
Try double install with cache
ZanSara Jan 28, 2022
66e0ca0
Try to cache more stuff, on a per-commit basis
ZanSara Jan 28, 2022
340acda
Trigger cache miss
ZanSara Jan 28, 2022
a754ddb
Try to cache docker images
ZanSara Jan 28, 2022
664527e
make prepare-build wait for docker-cache
ZanSara Jan 28, 2022
12119fb
Actually pull Docker cache in build
ZanSara Jan 28, 2022
e9327f7
Add date to build step
ZanSara Jan 28, 2022
c098c2f
Remove failed attempt to cache images
ZanSara Jan 28, 2022
084d855
Fix windows CI too
ZanSara Jan 28, 2022
e79d3b0
Add comment on how to speed up the CI with better caching
ZanSara Jan 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove date and path from cache key
  • Loading branch information
@ZanSara
ZanSara committed Jan 28, 2022
commit 514c4157e5490cdaac60b1be6058ef7828a0b8a8
6 changes: 2 additions & 4 deletions .github/workflows/linux_ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,12 @@ jobs:
- uses: actions/setup-python@v2
with:
python-version: 3.7
- run: echo "date=$(date +'%Y-%m-%d')" >> $env:GITHUB_ENV
- name: Cache
id: cache-python-env
uses: actions/cache@v2
with:
path: ${{ env.pythonLocation }}
key: linux-${{ env.pythonLocation }}-${{ env.date }}-${{ hashFiles('**/*.py') }}-${{ hashFiles('setup.cfg') }}-${{ hashFiles('pyproject.toml') }}
key: linux-${{ hashFiles('**/*.py') }}-${{ hashFiles('setup.cfg') }}-${{ hashFiles('pyproject.toml') }}
- name: Install dependencies
if: steps.cache-python-env.outputs.cache-hit != 'true'
run: |
Expand Down Expand Up @@ -65,12 +64,11 @@ jobs:
uses: actions/setup-python@v2
with:
python-version: 3.7
- run: echo "date=$(date +'%Y-%m-%d')" >> $GITHUB_ENV
- name: Cache
uses: actions/cache@v2
with:
path: ${{ env.pythonLocation }}
key: linux-${{ env.pythonLocation }}-${{ env.date }}-${{ hashFiles('**/*.py') }}-${{ hashFiles('setup.cfg') }}-${{ hashFiles('pyproject.toml') }}
key: linux-${{ hashFiles('**/*.py') }}-${{ hashFiles('setup.cfg') }}-${{ hashFiles('pyproject.toml') }}
- name: Run Elasticsearch
run: docker run -d -p 9200:9200 -e "discovery.type=single-node" -e "ES_JAVA_OPTS=-Xms128m -Xmx128m" elasticsearch:7.9.2

Expand Down
6 changes: 2 additions & 4 deletions .github/workflows/windows_ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,12 @@ jobs:
- uses: actions/setup-python@v2
with:
python-version: 3.7
- run: echo "date=$(date +'%Y-%m-%d')" >> $env:GITHUB_ENV
- name: Cache
id: cache-python-env
uses: actions/cache@v2
with:
path: ${{ env.pythonLocation }}
key: windows-${{ env.pythonLocation }}-${{ env.date }}-${{ hashFiles('**/*.py') }}-${{ hashFiles('setup.cfg') }}-${{ hashFiles('pyproject.toml') }}
key: windows-${{ hashFiles('**/*.py') }}-${{ hashFiles('setup.cfg') }}-${{ hashFiles('pyproject.toml') }}
- name: Install Pytorch on windows
run: |
pip install torch==1.8.1+cpu -f https://download.pytorch.org/whl/lts/1.8/torch_lts.html
Expand Down Expand Up @@ -71,12 +70,11 @@ jobs:
uses: actions/setup-python@v2
with:
python-version: 3.7
- run: echo "date=$(date +'%Y-%m-%d')" >> $env:GITHUB_ENV
- name: Cache
uses: actions/cache@v2
with:
path: ${{ env.pythonLocation }}
key: windows-${{ env.pythonLocation }}-${{ env.date }}-${{ hashFiles('**/*.py') }}-${{ hashFiles('setup.cfg') }}-${{ hashFiles('pyproject.toml') }}
key: windows-${{ hashFiles('**/*.py') }}-${{ hashFiles('setup.cfg') }}-${{ hashFiles('pyproject.toml') }}

# Windows runner can't run Linux containers. Refer https://github.com/actions/virtual-environments/issues/1143
- name: Set up Windows test env
Expand Down