Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable cache on the CI #2083

Merged
merged 20 commits into from
Jan 28, 2022
Merged

Disable cache on the CI #2083

merged 20 commits into from
Jan 28, 2022

Conversation

ZanSara
Copy link
Contributor

@ZanSara ZanSara commented Jan 28, 2022

It makes impossible to run tests reliably, as the cache will prevent the runner from picking up the latest code changes somehow.

While debugging this issue, let's disable the cache to not disrupt other PRs.

@ZanSara ZanSara requested a review from tstadel January 28, 2022 09:36
@ZanSara ZanSara added topic:tests type:bug Something isn't working labels Jan 28, 2022
@ZanSara
Copy link
Contributor Author

ZanSara commented Jan 28, 2022

Rather than disabling, this PR ends up just raising the frequency of cache misses to a per-commit basis. Before, cache lasted a full day and without an editable install it would not pick up code changes from the latest commit. With per-commit cache misses, the editable install is not needed anymore, and the whole pipeline execution time increases by just a couple of minutes.

@ZanSara ZanSara merged commit 07cf3c6 into master Jan 28, 2022
@ZanSara ZanSara deleted the disable_ci_caching branch January 28, 2022 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic:tests type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants