Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add download attribute #49

Merged
merged 2 commits into from
Nov 23, 2022
Merged

add download attribute #49

merged 2 commits into from
Nov 23, 2022

Conversation

carlosgauci
Copy link
Collaborator

Added "download" attribute to force downloads on the download button.

@vercel
Copy link

vercel bot commented Nov 9, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
haystack-home ✅ Ready (Inspect) Visit Preview Nov 20, 2022 at 7:37AM (UTC)

@carlosgauci carlosgauci mentioned this pull request Nov 9, 2022
Closed
TuanaCelik
TuanaCelik requested changes Nov 18, 2022
View reviewed changes
Copy link
Member

@TuanaCelik TuanaCelik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @carlosgauci - let's do this how you and @masci suggested in #49

@carlosgauci
Copy link
Collaborator Author

Hey @carlosgauci - let's do this how you and @masci suggested in #49

@TuanaCelik I've updated the build script to include the downloads, now they can be downloaded from that directory eg: https://haystack-home-hxuzlymld-deepset-overnice.vercel.app/downloads/01_Basic_QA_Pipeline.ipynb

TuanaCelik
TuanaCelik reviewed Nov 22, 2022
View reviewed changes
Copy link
Member

@TuanaCelik TuanaCelik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. As far as I can understand from testing locally, if the following exists in a .md file for a tutorial, a download button is generated and works correct?
download: "/downloads/01_Basic_QA_Pipeline.ipynb"
All good from my side if this is the case. @masci wbu?

masci
masci approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@TuanaCelik TuanaCelik merged commit ca467a6 into main Nov 23, 2022
@TuanaCelik TuanaCelik deleted the download-button branch November 23, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masci masci masci approved these changes

@TuanaCelik TuanaCelik TuanaCelik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@carlosgauci @masci @TuanaCelik