-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Download button for tutorials #48
Comments
Hey @carlosgauci - Yes indeed, but from what I remember there was still some functionality to add no? When I click that button I got a json file in the browser. It didn't download the |
@TuanaCelik You're right I opened a PR: #49 to force downloads on the button. The files to be downloaded should be in the static directory though so I don't think you can re-use the same colab URL unless they provide a direct download link. |
Ah ok, so the |
I think the best way would be to modify the build script that @masci added, to also copy over the .ipynb files into static/downloads, then you can serve the downloads from there easily. |
Sounds good, wdyt @masci ? |
Ok to include the notebooks in the Hugo build without checking them into the repo 👍 |
Tutorials have the following in the frontmatter:
We would like to also have a 'download' button at the top too.
@masci - is it worth asking contributors to provide a
download
field in haystack-tutorialsindex.toml
? - I would imagine everything should be 'downloadable'? In which case we could just re-use the colab field URL to download the file?The text was updated successfully, but these errors were encountered: