Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add filter_policy to mongodb_atlas integration #823

Merged
merged 19 commits into from
Jul 5, 2024

Conversation

vblagoje
Copy link
Member

@vblagoje vblagoje commented Jun 19, 2024

Why:

Adds flexible filtering options to mongodb_atlas integration. By introducing a filter policy option (replace or merge), developers can now control how runtime filters are applied relative to initialization time filters.

What:

  • Added filter_policy parameter with options replace and merge across multiple retrievers to control filter behavior dynamically.
  • Unit tests were updated or added to validate the new functionality.

How can it be used:

  • Dynamic Filter Behavior Adjustment: Users can decide whether to completely override the initial filters set during the retriever's initialization (replace) or merge them with runtime filters, with the latter taking precedence (merge).

  • Complex Search Scenarios:

    • In cases where the context of a query might dictate altering pre-set filters without discarding them, the merge option allows for an additive approach.
    • For strict query contexts that require ignoring initial filters, the replace option offers a clean slate for filters at runtime.

How did you test it:

  • Unit tests were enhanced or newly created to cover both replace and merge scenarios for the filter_policy parameter.
  • Tests ensure that filter logic is correctly applied based on the policy setting, whether it merges runtime filters with initial filters or replaces them entirely.
  • Additional test cases should be considered for complex filter merge scenarios to ensure priority and override mechanisms function as expected.

@vblagoje vblagoje requested a review from a team as a code owner June 19, 2024 12:45
@vblagoje vblagoje requested review from davidsbatista and removed request for a team June 19, 2024 12:45
@github-actions github-actions bot added integration:mongodb-atlas type:documentation Improvements or additions to documentation labels Jun 19, 2024
@@ -108,7 +114,11 @@ def run(
:returns: A dictionary with the following keys:
- `documents`: List of Documents most similar to the given `query_embedding`
"""
filters = filters or self.filters
if self.filter_policy == "merge" and filters:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems there's a test missing for this condition (filter_policy = 'merge'), no? and what happens if but for some reason filters = None

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, missing test, noted. If filters is None then else is executed and filters become either defined by user or {}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add merge use case to all PRs

@vblagoje
Copy link
Member Author

Please delay review until a new patch release of 2.2.x is released. We need these two PRs to be included in a patch release first.

@vblagoje
Copy link
Member Author

vblagoje commented Jul 4, 2024

Ready for review now @davidsbatista

  • Since you last looked at this PR we introduced apply_filter_policy function that is used by all Retrievers in this PR and we thoroughly tested that function in that PR. We then just applied it here in run method
  • Please note if FilterPolicy type is used consistently both in init and in run, and that it is documented well

@vblagoje
Copy link
Member Author

vblagoje commented Jul 5, 2024

Stefano recommended one more small improvement. Please hold your review until a new commit with it is added here

@vblagoje
Copy link
Member Author

vblagoje commented Jul 5, 2024

@davidsbatista please have a look at #827 @anakin87 has already gone through a through review of Astra and should help you validate this PR is well-aligned as well

@vblagoje vblagoje merged commit 124b6e8 into main Jul 5, 2024
13 checks passed
@vblagoje vblagoje deleted the filter-policy-mongodb_atlas branch July 5, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration:mongodb-atlas type:documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add filter_policy init parameter to all retrievers
2 participants