Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add filter_policy to astra integration #827

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

vblagoje
Copy link
Member

@vblagoje vblagoje commented Jun 19, 2024

Why:

Adds flexible filtering options to astra integration. By introducing a filter policy option (replace or merge), developers can now control how runtime filters are applied relative to initialization time filters.

What:

  • Added filter_policy parameter with options replace and merge across multiple retrievers to control filter behavior dynamically.
  • Unit tests were updated or added to validate the new functionality.

How can it be used:

  • Dynamic Filter Behavior Adjustment: Users can decide whether to completely override the initial filters set during the retriever's initialization (replace) or merge them with runtime filters, with the latter taking precedence (merge).

  • Complex Search Scenarios:

    • In cases where the context of a query might dictate altering pre-set filters without discarding them, the merge option allows for an additive approach.
    • For strict query contexts that require ignoring initial filters, the replace option offers a clean slate for filters at runtime.

How did you test it:

  • Unit tests were enhanced or newly created to cover both replace and merge scenarios for the filter_policy parameter.
  • Tests ensure that filter logic is correctly applied based on the policy setting, whether it merges runtime filters with initial filters or replaces them entirely.
  • Additional test cases should be considered for complex filter merge scenarios to ensure priority and override mechanisms function as expected.

@vblagoje vblagoje requested a review from a team as a code owner June 19, 2024 12:48
@vblagoje vblagoje requested review from anakin87 and removed request for a team June 19, 2024 12:48
@github-actions github-actions bot added integration:astra type:documentation Improvements or additions to documentation labels Jun 19, 2024
@vblagoje
Copy link
Member Author

Please delay review until a new patch release of 2.2.x is released. We need these two PRs to be included in a patch release first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration:astra type:documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add filter_policy init parameter to all retrievers
1 participant