Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use scan_table to apply custom filters #1179

Merged
merged 52 commits into from
Jul 1, 2023

Conversation

rjzamora
Copy link
Contributor

Adds changes from #1140 to #1173

NOTE:

@rjzamora rjzamora marked this pull request as ready for review June 21, 2023 18:45
@charlesbluca
Copy link
Collaborator

cc @rjzamora looks like we're seeing some Python failures, seemingly around handling of IS NOT NULL - have any bandwidth to take a look?

@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2023

Codecov Report

Merging #1179 (1bbaac1) into main (371315c) will decrease coverage by 0.01%.
The diff coverage is 83.78%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main    #1179      +/-   ##
==========================================
- Coverage   81.84%   81.84%   -0.01%     
==========================================
  Files          78       78              
  Lines        4539     4566      +27     
  Branches      837      846       +9     
==========================================
+ Hits         3715     3737      +22     
+ Misses        642      640       -2     
- Partials      182      189       +7     
Impacted Files Coverage Δ
dask_sql/physical/utils/filter.py 83.57% <68.42%> (+1.65%) ⬆️
dask_sql/physical/rel/logical/filter.py 84.84% <100.00%> (ø)
dask_sql/physical/rel/logical/table_scan.py 94.73% <100.00%> (+1.55%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ayushdg ayushdg merged commit ca8f963 into dask-contrib:main Jul 1, 2023
19 checks passed
@rjzamora rjzamora deleted the add-table-scan-filters branch July 5, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants