Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom filters to attempt_predicate_pushdown #1173

Merged
merged 7 commits into from
Jun 21, 2023

Conversation

rjzamora
Copy link
Contributor

@rjzamora rjzamora commented Jun 7, 2023

Follow-up to #1160

Makes it possible to combine (1) pre-existing, (2) extracted, and (3) manually-specified filters within attempt_predicate_pushdown. Here, we assume that these three kinds of filters must always be combined as an and conjunction. However, any one of these three kinds of filters may correspond to a general Or(And(...), ...) DNF expression.

@rjzamora
Copy link
Contributor Author

rjzamora commented Jun 7, 2023

@ayushdg - This kind of functionality should make it a lot easier to manually "add on" filters that cannot be extracted from the graph.

@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2023

Codecov Report

Merging #1173 (439bed6) into main (219f015) will increase coverage by 0.16%.
The diff coverage is 82.55%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main    #1173      +/-   ##
==========================================
+ Coverage   81.42%   81.59%   +0.16%     
==========================================
  Files          78       78              
  Lines        4474     4509      +35     
  Branches      817      828      +11     
==========================================
+ Hits         3643     3679      +36     
+ Misses        650      644       -6     
- Partials      181      186       +5     
Impacted Files Coverage Δ
dask_sql/physical/utils/filter.py 81.92% <82.55%> (+1.03%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@ayushdg ayushdg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this @rjzamora

@rjzamora
Copy link
Contributor Author

Thanks for the review @ayushdg - Note that we may also want to include this update to normalize (though it is already in #1179, so the subtle "fix" can also remain separate)

@ayushdg ayushdg merged commit 68853a5 into dask-contrib:main Jun 21, 2023
19 checks passed
@rjzamora rjzamora deleted the custom-filter-support branch June 21, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants