Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually skip on windows #478

Merged
merged 4 commits into from
Jul 9, 2019
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion appveyor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ install:
build: off

test_script:
- C:\tools\dart-sdk\bin\pub.bat run test -j 1 --run-skipped
- C:\tools\dart-sdk\bin\pub.bat run test -j 1

cache:
- C:\Users\appveyor\AppData\Roaming\Pub\Cache
6 changes: 0 additions & 6 deletions webdev/dart_test.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1 @@
tags:
presubmit-only:
skip: "Should only be run during presubmit"
webdriver:
skip: "Should only be run during presubmit"

retry: 3
2 changes: 0 additions & 2 deletions webdev/test/build/ensure_build_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

@Tags(['presubmit-only'])

import 'package:build_verify/build_verify.dart';
import 'package:test/test.dart';

Expand Down
2 changes: 1 addition & 1 deletion webdev/test/daemon/app_domain_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -142,5 +142,5 @@ void main() {
expect(await webdev.exitCode, equals(0));
});
});
}, tags: ['webdriver']);
});
}
2 changes: 1 addition & 1 deletion webdev/test/daemon/daemon_domain_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -48,5 +48,5 @@ void main() {
expect(await webdev.exitCode, equals(0));
});
});
}, tags: ['webdriver']);
});
}
1 change: 0 additions & 1 deletion webdev/test/serve/injected/devtools_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
// BSD-style license that can be found in the LICENSE file.

@Timeout(Duration(minutes: 5))
@Tags(['webdriver'])
import 'dart:async';
import 'dart:io';

Expand Down
2 changes: 1 addition & 1 deletion webdev/test/serve/injected/reload_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -114,5 +114,5 @@ void main() {

await fixture.webdev.kill();
});
}, tags: ['webdriver']);
});
}
1 change: 0 additions & 1 deletion webdev/test/serve/screenshot_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
// BSD-style license that can be found in the LICENSE file.

@Timeout(Duration(minutes: 1))
@Tags(['webdriver'])
import 'dart:io';

import 'package:test/test.dart';
Expand Down