Actually skip on windows #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We could fix that by tweaking dart_test.yaml...I think |
kevmoo
approved these changes
Jul 8, 2019
|
This won't warn that we are skipping the test though now.... I would file an issue to keep track of re-enabling this test. |
|
Discussed offline. Got rid of the skip silliness as we mostly run all tests locally anyway. We already have a tracking issue to unskip this Windows test. |
kevmoo
approved these changes
Jul 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should come up with a better pattern. Not really sure why we do this
--run-skippedsilliness to begin with.