Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(sdf): separate out resources.py #23239

Merged
merged 1 commit into from
Jul 26, 2024
Merged

refactor(sdf): separate out resources.py #23239

merged 1 commit into from
Jul 26, 2024

Conversation

rexledesma
Copy link
Contributor

@rexledesma rexledesma commented Jul 25, 2024 •
edited
Loading

Summary & Motivation

Basically the same as #23154, #23161, and #23209, but for dagster-sdf.

How I Tested These Changes

bk

@rexledesma rexledesma mentioned this pull request Jul 25, 2024
Merged
@rexledesma Graphite App
Copy link
Contributor Author

rexledesma commented Jul 25, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rexledesma and the rest of your teammates on Graphite Graphite

@rexledesma rexledesma force-pushed the rl/separate-out-sdf-resource branch from c5f3ecd to 6cd6bbd Compare July 25, 2024 20:40
@rexledesma rexledesma mentioned this pull request Jul 25, 2024
Merged
@rexledesma rexledesma force-pushed the rl/separate-out-sdf-resource branch from 6cd6bbd to f010281 Compare July 25, 2024 21:04
@rexledesma rexledesma force-pushed the rl/separate-out-sdf-resource branch from f010281 to 33873cc Compare July 25, 2024 22:22
Base automatically changed from rl/rename-sdf-files to master July 26, 2024 02:23
@rexledesma rexledesma force-pushed the rl/separate-out-sdf-resource branch from 33873cc to 0917d6a Compare July 26, 2024 02:23
cmpadden
cmpadden approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@cmpadden cmpadden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fabuloso - pending bk

@rexledesma rexledesma merged commit 3ee4fb3 into master Jul 26, 2024
1 check was pending
@rexledesma Graphite App
Copy link
Contributor Author

Merge activity

@rexledesma rexledesma deleted the rl/separate-out-sdf-resource branch July 26, 2024 02:26
@cmpadden cmpadden mentioned this pull request Jul 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmpadden cmpadden cmpadden approved these changes

@benpankow benpankow Awaiting requested review from benpankow

@maximearmstrong maximearmstrong Awaiting requested review from maximearmstrong

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rexledesma @cmpadden