Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(dbt): separate out DbtCliEventMessage to dbt_cli_event.py #23154

Merged
merged 1 commit into from
Jul 23, 2024
Merged

refactor(dbt): separate out DbtCliEventMessage to dbt_cli_event.py #23154

merged 1 commit into from
Jul 23, 2024
+493 −450

Conversation

rexledesma
Copy link
Contributor

Summary & Motivation

resource.py is over 2000 lines. Let's separate out its components to make the file more tractable.

Start by separating out DbtCliEventMessage.

How I Tested These Changes

bk

@rexledesma rexledesma mentioned this pull request Jul 22, 2024
Merged
@rexledesma Graphite App
Copy link
Contributor Author

rexledesma commented Jul 22, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rexledesma and the rest of your teammates on Graphite Graphite

sryza
sryza approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@sryza sryza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ ❤️ ❤️

@rexledesma rexledesma force-pushed the rl/separate-out-dbt-cli-event branch from c85bca8 to e8731c0 Compare July 23, 2024 00:46
@rexledesma rexledesma mentioned this pull request Jul 23, 2024
Merged
Base automatically changed from rl/no-more-v2 to master July 23, 2024 01:12
@graphite-app graphite-app bot added the area: docs Related to documentation in general label Jul 23, 2024
@rexledesma rexledesma force-pushed the rl/separate-out-dbt-cli-event branch 2 times, most recently from 8ed63b5 to 6db4322 Compare July 23, 2024 01:14
@rexledesma rexledesma force-pushed the rl/separate-out-dbt-cli-event branch from 6db4322 to 7177da8 Compare July 23, 2024 01:17
@rexledesma rexledesma merged commit 65001b3 into master Jul 23, 2024
1 check was pending
@rexledesma rexledesma deleted the rl/separate-out-dbt-cli-event branch July 23, 2024 01:31
@rexledesma rexledesma mentioned this pull request Jul 25, 2024
Merged
rexledesma added a commit that referenced this pull request Jul 26, 2024
@rexledesma
refactor(sdf): separate out resources.py (#23239)
3ee4fb3 
## Summary & Motivation
Basically the same as #23154,
#23161, and
#23209, but for `dagster-sdf`.

## How I Tested These Changes
bk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sryza sryza sryza approved these changes

@benpankow benpankow Awaiting requested review from benpankow

@maximearmstrong maximearmstrong Awaiting requested review from maximearmstrong

@erinkcochran87 erinkcochran87 Awaiting requested review from erinkcochran87

Assignees
No one assigned
Labels
area: docs Related to documentation in general
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rexledesma @sryza