Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[serdes] deserialize_values #23186

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Conversation

alangenfeld
Copy link
Member

Adds a path for avoiding re-entering context managers for each value when deserializing a list of items

How I Tested These Changes

updated some callsites, existing tests

Copy link
Member Author

alangenfeld commented Jul 23, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @alangenfeld and the rest of your teammates on Graphite Graphite

@alangenfeld alangenfeld force-pushed the al/07-23-_serdes_don_t_recreate_type_map branch from 7c8a7dd to 6103eb4 Compare July 23, 2024 21:44
@alangenfeld alangenfeld force-pushed the al/07-23-_serdes_deserialize_values branch from 70abd70 to f027294 Compare July 23, 2024 21:44
@alangenfeld alangenfeld force-pushed the al/07-23-_serdes_don_t_recreate_type_map branch from 6103eb4 to be374e8 Compare July 23, 2024 22:13
@alangenfeld alangenfeld force-pushed the al/07-23-_serdes_deserialize_values branch 2 times, most recently from 047991f to c46de35 Compare July 23, 2024 22:17
Base automatically changed from al/07-23-_serdes_don_t_recreate_type_map to master July 24, 2024 14:22
Copy link
Contributor

@jamiedemaria jamiedemaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

@alangenfeld alangenfeld merged commit e298409 into master Jul 24, 2024
1 check passed
@alangenfeld alangenfeld deleted the al/07-23-_serdes_deserialize_values branch July 24, 2024 16:02
sryza pushed a commit that referenced this pull request Jul 24, 2024
Adds a path for avoiding re-entering context managers for each value
when deserializing a list of items

## How I Tested These Changes

updated some callsites, existing tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants