Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[serdes] don't recreate type map #23182

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

alangenfeld
Copy link
Member

build it up on register instead

How I Tested These Changes

bk

Copy link
Member Author

alangenfeld commented Jul 23, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @alangenfeld and the rest of your teammates on Graphite Graphite

@alangenfeld alangenfeld force-pushed the al/07-23-_serdes_don_t_recreate_type_map branch from 9eb3769 to 7c8a7dd Compare July 23, 2024 20:38
Copy link
Member

@gibsondan gibsondan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perf win? what's the before/after like?

@alangenfeld alangenfeld force-pushed the al/07-23-_serdes_don_t_recreate_type_map branch from 7c8a7dd to 6103eb4 Compare July 23, 2024 21:44
@alangenfeld
Copy link
Member Author

perf win? what's the before/after like?

yea this was having outsized cost observed in a sensor daemon

Screenshot 2024-07-23 at 5 07 53 PM

didn't measure the after

@alangenfeld alangenfeld force-pushed the al/07-23-_serdes_don_t_recreate_type_map branch from 6103eb4 to be374e8 Compare July 23, 2024 22:13
@alangenfeld alangenfeld merged commit 0ebce2d into master Jul 24, 2024
1 check passed
@alangenfeld alangenfeld deleted the al/07-23-_serdes_don_t_recreate_type_map branch July 24, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants