Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reverted internal prefix for every backend except Dafny #5538

Merged
merged 6 commits into from
Jun 10, 2024
Merged

Reverted internal prefix for every backend except Dafny #5538

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e40b3b2
Reverted internal prefix for every backend except Dafny
MikaelMayer Jun 7, 2024
484b61d
Merge branch 'master' into chore-compatibility-mpl
MikaelMayer Jun 7, 2024
33fb556
Fixed one CI test
MikaelMayer Jun 7, 2024
dabb2f6
Merge branch 'master' into chore-compatibility-mpl
robin-aws Jun 7, 2024
e077cc5
Merge branch 'chore-compatibility-mpl' of https://github.com/dafny-la…
MikaelMayer Jun 7, 2024
52b8c26
Merge branch 'master' into chore-compatibility-mpl
MikaelMayer Jun 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Source/DafnyCore/Backends/SinglePassCodeGenerator/SinglePassCodeGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public abstract partial class SinglePassCodeGenerator {
// we can prefix it with "_".
// However, for backends such as Rust which need special internal fields, we want to clearly
// disambiguate between compiler-generated names and user-defined names, hence this prefix.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not worth extra CI runs to fix, but sounds like this comment isn't accurate any more?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not completely accurate, but still indicates why this prefix isn't hard-coded at least.

protected virtual string InternalFieldPrefix => "_i_";
protected virtual string InternalFieldPrefix => "_";
public DafnyOptions Options { get; }

/// <summary>
Expand Down
Loading
Loading