Reverted internal prefix for every backend except Dafny #5538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robin-aws
previously approved these changes
Jun 7, 2024
| @@ -29,7 +29,7 @@ public abstract partial class SinglePassCodeGenerator { | |||
| // we can prefix it with "_". | |||
| // However, for backends such as Rust which need special internal fields, we want to clearly | |||
| // disambiguate between compiler-generated names and user-defined names, hence this prefix. | |||
There was a problem hiding this comment.
Not worth extra CI runs to fix, but sounds like this comment isn't accurate any more?
There was a problem hiding this comment.
Not completely accurate, but still indicates why this prefix isn't hard-coded at least.
It's here It's used here: and it's overriden in the Dafny code generator using this assigned private variabe |
…ng/dafny into chore-compatibility-mpl
robin-aws
approved these changes
Jun 7, 2024
| // However, for backends such as Rust which need special internal fields, we want to clearly | ||
| // disambiguate between compiler-generated names and user-defined names, hence this prefix. | ||
| protected virtual string InternalFieldPrefix => "_i_"; | ||
| // This prefix can be overridden as necessary by backends. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some clients using Smithy-Dafny were stuck because we changed the internal field prefix. We revert it in this PR by convenience for them as we don't have an immediate need for this enhanced prefix.
How has this been tested?
All tests should pass.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.