Added test, remove dead code (seems to be already fixed?)

Source/DafnyCore/Compilers/GoLang/Compiler-go.cs

@@ -1402,9 +1402,7 @@ protected class ClassWriter : IClassWriter {
  Contract.Assume(type != null); // precondition; this ought to be declared as a Requires in the superclass
 
  var xType = DatatypeWrapperEraser.SimplifyType(type);
- if (xType is SpecialNativeType snt) {
- return snt.Name;
- } else if (xType is BoolType) {
+ if (xType is BoolType) {
  return "bool";
  } else if (xType is CharType) {
  return CharTypeName;
@@ -1675,21 +1673,6 @@ protected class ClassWriter : IClassWriter {
  return Capitalize(formal.CompileName);
  }
 
- protected override Type NativeForm(Type type) {
- if (type.IsStringType) {
- return NativeStringType;
- } else {
- return type;
- }
- }
-
- /// A type which is rendered to Go exactly as specified. Used to represent the native string type.
- private class SpecialNativeType : UserDefinedType {
- internal SpecialNativeType(string name) : base(Token.NoToken, name, null) { }
- }
-
- private readonly static SpecialNativeType NativeStringType = new SpecialNativeType("string");
-
  // ----- Declarations -------------------------------------------------------------
 
  protected void DeclareField(string name, bool isExtern, bool isStatic, bool isConst, Type type, IToken tok, string/*?*/ rhs, string className, ConcreteSyntaxTree wr, ConcreteSyntaxTree initWriter, ConcreteSyntaxTree concreteMethodWriter) {

Test/git-issues/github-issue-2989.dfy

@@ -0,0 +1,13 @@
+// RUN: %translate go --unicode-char:false "%s" > "%t"
+// RUN: %translate go --unicode-char:true "%s" >> "%t"
+// RUN: %diff "%s.expect" "%t" 
+
+method Main() {
+ var s := Foo();
+}
+
+method {:extern "foo"} Foo() returns (s: string)
+
+method Bar() returns (s: string) {
+ return "hello";
+}