Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: Disable automatically mapping a Dafny string to a Go string in externs #3647

Merged
merged 12 commits into from
Feb 28, 2023
Merged

fix!: Disable automatically mapping a Dafny string to a Go string in externs #3647

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
78ae250
Added test, remove dead code (seems to be already fixed?)
robin-aws Feb 24, 2023
99af432
Merge branch 'main-4.0' of https://github.com/dafny-lang/dafny into g…
robin-aws Feb 27, 2023
21269cc
Disabled the feature, test almost working except for unused imports
robin-aws Feb 27, 2023
ee2a3e9
Moved GoModule.dfy to wishlist as negative test
robin-aws Feb 27, 2023
468d719
Fix and document test
robin-aws Feb 27, 2023
9fadc90
whitespace
robin-aws Feb 27, 2023
96961f9
More whitespace
robin-aws Feb 27, 2023
13b09ae
Align with the ordering I did on the other PR :)
robin-aws Feb 27, 2023
060c997
Merge branch 'main-4.0' of https://github.com/dafny-lang/dafny into g…
robin-aws Feb 27, 2023
5164558
Use OutputCheck pattern to avoid file paths variance in CI
robin-aws Feb 28, 2023
02bdcf9
Merge branch 'main-4.0' into github-issue-2989
robin-aws Feb 28, 2023
35544c7
Merge branch 'main-4.0' into github-issue-2989
robin-aws Feb 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use OutputCheck pattern to avoid file paths variance in CI
  • Loading branch information
@robin-aws
robin-aws committed Feb 28, 2023
commit 5164558a833d546f7b4533da04f402fb4c70cfa0
3 changes: 2 additions & 1 deletion Test/wishlist/GoModule.dfy
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// RUN: %exits-with 3 %dafny /compile:3 /unicodeChar:0 /spillTargetCode:2 "%s" /compileTarget:go 2> "%t"
// note: putting /compileTarget:go after "%s" overrides user-provided option
// RUN: %diff "%s.expect" "%t"
// RUN: %OutputCheck --file-to-check "%t" "%s"
// CHECK: GoModuleConversions.go:10:3: imported and not used: "net/url"

// This test used to work only because of a questionable Go-only feature
// of mapping a Dafny string directly to a Go string when passed in or out of
Expand Down
2 changes: 0 additions & 2 deletions Test/wishlist/GoModule.dfy.expect
View file
Open in desktop

This file was deleted.