Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify build workflow #469

Merged
merged 11 commits into from
Jun 26, 2024
Merged

Simplify build workflow #469

merged 11 commits into from
Jun 26, 2024

Conversation

s-zanella
Copy link

This was automatically closed as part of another merge (cf. #464). Re-opening after rebasing on dev.

  • Use CMake presets to unify multi-config builds with Ninja using MSVC and Clang. Works on VS, VS code, and CLI.
  • Document how to install dependencies on Windows using winget.
  • Let CMake generate appropriate config.h files instead of manually copying default configs for MSVC and Clang.

@s-zanella s-zanella requested a review from a team as a code owner May 20, 2024 12:01
Copy link

cla-bot bot commented May 20, 2024

We require contributors to sign our Contributor License Agreement https://github.com/cryspen/hacl/blob/main/CLA.md ensuring that the contribution can be licensed under Apache 2.0 and MIT. In order for us to review and merge your code, please mention @cryspen/core in a comment below to get yourself added.

@coveralls
Copy link

coveralls commented Jun 5, 2024

Pull Request Test Coverage Report for Build 9158340974

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 59.064%

Totals Coverage Status
Change from base Build 9096505835: 0.0%
Covered Lines: 38622
Relevant Lines: 65390

💛 - Coveralls

Copy link

cla-bot bot commented Jun 21, 2024

We require contributors to sign our Contributor License Agreement https://github.com/cryspen/hacl/blob/main/CLA.md ensuring that the contribution can be licensed under Apache 2.0 and MIT. In order for us to review and merge your code, please mention @cryspen/core in a comment below to get yourself added.

Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, let's finally get this in.

@coveralls
Copy link

coveralls commented Jun 21, 2024

Pull Request Test Coverage Report for Build 9609869829

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 59.064%

Totals Coverage Status
Change from base Build 9609866152: 0.0%
Covered Lines: 38622
Relevant Lines: 65390

💛 - Coveralls

@franziskuskiefer franziskuskiefer merged commit c8c980d into cryspen:dev Jun 26, 2024
38 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants