Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify build workflow #464

Conversation

s-zanella
Copy link

  • Use CMake presets to unify multi-config builds with Ninja using MSVC and Clang. Works on VS, VS code, and CLI.
  • Document how to install dependencies on Windows using winget.
  • Let CMake generate appropriate config.h files instead of manually copying default configs for MSVC and Clang.

@s-zanella s-zanella requested a review from a team as a code owner May 8, 2024 15:37
Copy link

cla-bot bot commented May 8, 2024

We require contributors to sign our Contributor License Agreement https://github.com/cryspen/hacl/blob/main/CLA.md ensuring that the contribution can be licensed under Apache 2.0 and MIT. In order for us to review and merge your code, please mention @cryspen/core in a comment below to get yourself added.

Copy link

cla-bot bot commented May 8, 2024

We require contributors to sign our Contributor License Agreement https://github.com/cryspen/hacl/blob/main/CLA.md ensuring that the contribution can be licensed under Apache 2.0 and MIT. In order for us to review and merge your code, please mention @cryspen/core in a comment below to get yourself added.

@franziskuskiefer franziskuskiefer self-requested a review May 9, 2024 18:25
Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Getting this unified would be great.
But running this fails for me right now because it's trying to find the default_config.h

hacl-packages\tools\configure.py", line 154, in __init__
    shutil.copyfile(
  File "C:\Python312\Lib\shutil.py", line 260, in copyfile
    with open(src, 'rb') as fsrc:
         ^^^^^^^^^^^^^^^
FileNotFoundError: [Errno 2] No such file or directory: 'config\\default_config.h'

README.md Show resolved Hide resolved
Co-authored-by: Franziskus Kiefer <[email protected]>
Copy link

cla-bot bot commented May 10, 2024

We require contributors to sign our Contributor License Agreement https://github.com/cryspen/hacl/blob/main/CLA.md ensuring that the contribution can be licensed under Apache 2.0 and MIT. In order for us to review and merge your code, please mention @cryspen/core in a comment below to get yourself added.

Copy link

cla-bot bot commented May 10, 2024

We require contributors to sign our Contributor License Agreement https://github.com/cryspen/hacl/blob/main/CLA.md ensuring that the contribution can be licensed under Apache 2.0 and MIT. In order for us to review and merge your code, please mention @cryspen/core in a comment below to get yourself added.

Copy link

cla-bot bot commented May 10, 2024

We require contributors to sign our Contributor License Agreement https://github.com/cryspen/hacl/blob/main/CLA.md ensuring that the contribution can be licensed under Apache 2.0 and MIT. In order for us to review and merge your code, please mention @cryspen/core in a comment below to get yourself added.

@s-zanella
Copy link
Author

Thanks! Getting this unified would be great. But running this fails for me right now because it's trying to find the default_config.h

hacl-packages\tools\configure.py", line 154, in __init__
    shutil.copyfile(
  File "C:\Python312\Lib\shutil.py", line 260, in copyfile
    with open(src, 'rb') as fsrc:
         ^^^^^^^^^^^^^^^
FileNotFoundError: [Errno 2] No such file or directory: 'config\\default_config.h'

Thanks! I hadn't tested the configuration script. I restored config/default_config.h.

@franziskuskiefer
Copy link
Member

Thanks, this looks good. We have to figure out the CI failures, then we can get this in.

@franziskuskiefer franziskuskiefer deleted the branch cryspen:protz_all_kyber_variants May 15, 2024 13:23
@franziskuskiefer
Copy link
Member

Oh, no idea why I closed this. That wasn't intentional.
But looks like the branch is gone?

@s-zanella
Copy link
Author

Oh, no idea why I closed this. That wasn't intentional. But looks like the branch is gone?

No worries. This was opened against protz_all_kyber_variants which got deleted after another merge. I reopened it against dev as #469

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants