Sync Helm chart values table from crossplane/crossplane repo #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for crossplane ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Merged
6 tasks
1 task
plumbis
requested changes
Oct 18, 2023
There was a problem hiding this comment.
To maximize annoyances this fails Vale checking because we made vale do it's job better since the last time this was synced.
I opened crossplane/crossplane#4840 to put the fixes in the Crossplane templates.
Can you re copy/pasta and Vale should pass and I'll approve.
Signed-off-by: Jared Watts <[email protected]>
|
Your PR crossplane/crossplane#4841 has been merged @plumbis, so I copied over the latest from crossplane master and included it in this PR ✅ |
plumbis
approved these changes
Oct 20, 2023
negz
pushed a commit
to negz/docs
that referenced
this pull request
Oct 30, 2023
plumbis
pushed a commit
that referenced
this pull request
Oct 31, 2023
plumbis
pushed a commit
that referenced
this pull request
Nov 1, 2023
Signed-off-by: Pete Lumbis <[email protected]>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the table of Helm chart values to match the latest in https://github.com/crossplane/crossplane/blob/master/cluster/charts/crossplane/README.md.
This was spurred by crossplane/crossplane#4831 where the default value for
image.repositoryis changing, but I noticed a lot of other differences fromcrossplane/crossplanethat hadn't made their way over to the docs, so I just copied the whole thing over in its entirety.The history of recent changes to the helm chart readme in crossplane can be found at https://github.com/crossplane/crossplane/commits/master/cluster/charts/crossplane/README.md for curious reviewers.
Is there an process that could be in place to ensure the two stay in sync? 🤔
Affected page in the deployment preview (don't forget to expand the accordion!): https://deploy-preview-572--crossplane.netlify.app/master/software/install/#customize-the-crossplane-helm-chart