Add Topology Spread Constraints to Helm Chart

[blakeromano]

Description of your changes

Adds Topology Spread Constraints to the Helm Chart for Crossplane

Fixes # #5794

I have:

• Read and followed Crossplane's contribution process.
• Run earthly +reviewable to ensure this PR is ready for review.
• Added or updated unit tests.
• Added or updated e2e tests.
• Linked a PR or a docs tracking issue to document this change.
• Added backport release-x.y labels to auto-backport this PR.

Need help with this checklist? See the cheat sheet.

[blakeromano]

@bobh66 from what I can tell this check failure isn't true... I ran earthly +generate and I didn't see anything wrong there and did nothing with realtime-compositions in this PR so not sure if I need to do anything to get this pushed through

[bobh66]

@blakeromano did you run earthly +reviewable on the changes? That should detect the same issues that the build pipeline check is finding.

[blakeromano]

This is what I get as an output from earthly +reviewable

earthly +reviewable                                   
 Init 🚀
————————————————————————————————————————————————————————————————————————————————

           buildkitd | Found buildkit daemon as docker container (earthly-buildkitd)

 Build 🔧
————————————————————————————————————————————————————————————————————————————————

              logbus | Setting organization "crossplane" and project "crossplane"
         +reviewable | --> FROM +base
         +reviewable | --> BUILD +generate
           +generate | --> FROM +base
           +generate | --> BUILD +go-modules-tidy
    +go-modules-tidy | --> FROM +base
        +go-generate | --> FROM +base
      +helm-generate | --> FROM +base
    +go-modules-tidy | --> FROM +go-modules
         +go-modules | --> FROM +base
        +go-generate | --> FROM +go-modules
         alpine:3.20 | --> Load metadata alpine:3.20 linux/arm64
       golang:1.22.3 | --> Load metadata golang:1.22.3 linux/arm64
Warning: you are not logged into registry-1.docker.io, you may experience rate-limitting when pulling images
Warning: you are not logged into registry-1.docker.io, you may experience rate-limitting when pulling images
    +helm-docs-setup | --> FROM +base
        c/curl:8.8.0 | --> Load metadata curlimages/curl:8.8.0 linux/arm64
      +kubectl-setup | --> FROM +base
           +generate | --> BUILD +go-generate
         +go-modules | --> FROM golang:1.22.3
         +go-modules | [----------] 100% FROM golang:1.22.3
         +go-modules | *cached* --> WORKDIR /crossplane
         +go-modules | *cached* --> COPY go.mod go.sum ./
         +go-modules | *cached* --> RUN go mod download
Warning: you are not logged into registry-1.docker.io, you may experience rate-limitting when pulling images
    +go-modules-tidy | *cached* --> COPY --dir apis/ cmd/ internal/ pkg/ test/ .
    +go-modules-tidy | *cached* --> RUN go mod tidy
    +go-modules-tidy | *cached* --> RUN go mod verify
           +generate | --> BUILD +helm-generate
      +kubectl-setup | --> FROM curlimages/curl:8.8.0
      +kubectl-setup | [----------] 100% FROM curlimages/curl:8.8.0
    +helm-docs-setup | *cached* --> mkdir /run
    +helm-docs-setup | *cached* --> IF [ "${TARGETARCH}" = "amd64" ]
      +kubectl-setup | *cached* --> RUN curl -fsSL https://dl.k8s.io/${KUBECTL_VERSION}/kubernetes-client-${TARGETOS}-${TARGETARCH}.tar.gz|tar zx
    +helm-docs-setup | *cached* --> RUN curl -fsSL https://github.com/norwoodj/helm-docs/releases/download/v${HELM_DOCS_VERSION}/helm-docs_${HELM_DOCS_VERSION}_${TARGETOS}_${ARCH}.tar.gz|tar zx>helm-docs
      +helm-generate | --> FROM alpine:3.20
      +helm-generate | [----------] 100% FROM alpine:3.20
      +helm-generate | *cached* --> WORKDIR /chart
      +helm-generate | *cached* --> COPY +helm-docs-setup/helm-docs /usr/local/bin/helm-docs
      +helm-generate | *cached* --> COPY cluster/charts/crossplane/ .
      +helm-generate | *cached* --> RUN helm-docs
        +go-generate | *cached* --> COPY +kubectl-setup/kubectl /usr/local/bin/kubectl
        +go-generate | *cached* --> COPY --dir cluster/crd-patches cluster/crd-patches
        +go-generate | *cached* --> COPY --dir hack/ apis/ internal/ .
        +go-generate | *cached* --> RUN go generate -tags 'generate' ./apis/...
        +go-generate | *cached* --> RUN kubectl patch --local --type=json --patch-file cluster/crd-patches/pkg.crossplane.io_deploymentruntimeconfigs.yaml --filename cluster/crds/pkg.crossplane.io_deploymentruntimeconfigs.yaml --output=yaml > /tmp/patched.yaml && mv /tmp/patched.yaml cluster/crds/pkg.crossplane.io_deploymentruntimeconfigs.yaml
        +go-generate | *cached* --> SAVE ARTIFACT cluster/crds +go-generate/crds AS LOCAL cluster/crds
        +go-generate | *cached* --> SAVE ARTIFACT apis/ +go-generate/apis AS LOCAL apis
    +go-modules-tidy | *cached* --> SAVE ARTIFACT go.sum +go-modules-tidy/go.sum AS LOCAL go.sum
    +go-modules-tidy | *cached* --> SAVE ARTIFACT go.mod +go-modules-tidy/go.mod AS LOCAL go.mod
      +helm-generate | *cached* --> SAVE ARTIFACT . +helm-generate/chart AS LOCAL cluster/charts/crossplane
              output | --> exporting outputs
              output | sent 1 file stat
              output | [----------] 100% exporting outputs
         +reviewable | --> BUILD +lint
               +lint | --> FROM +base
               +lint | --> BUILD +go-lint
            +go-lint | --> FROM +base
          +helm-lint | --> FROM +base
            +go-lint | --> FROM +go-modules
         +helm-setup | --> FROM +base
               +lint | --> BUILD +helm-lint
         +reviewable | --> BUILD +test
               +test | --> FROM +base
               +test | --> BUILD +go-test
            +go-test | --> FROM +base
            +go-test | --> FROM +go-modules
         +helm-setup | *cached* --> RUN curl -fsSL https://get.helm.sh/helm-${HELM_VERSION}-${TARGETOS}-${TARGETARCH}.tar.gz|tar zx --strip-components=1
          +helm-lint | *cached* --> COPY +helm-setup/helm /usr/local/bin/helm
          +helm-lint | *cached* --> COPY cluster/charts/crossplane/ .
          +helm-lint | *cached* --> RUN helm lint
            +go-lint | *cached* --> RUN curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin ${GOLANGCI_LINT_VERSION}
            +go-lint | *cached* --> COPY .golangci.yml .
            +go-lint | *cached* --> COPY --dir apis/ cmd/ internal/ pkg/ test/ .
            +go-lint | *cached* --> RUN golangci-lint run --fix
            +go-lint | *cached* --> SAVE ARTIFACT apis +go-lint/apis AS LOCAL apis
            +go-test | *cached* --> COPY --dir apis/ cmd/ internal/ pkg/ .
            +go-test | *cached* --> RUN go test -covermode=count -coverprofile=coverage.txt ./...
            +go-test | *cached* --> SAVE ARTIFACT coverage.txt +go-test/coverage.txt AS LOCAL _output/tests/coverage.txt
            +go-lint | *cached* --> SAVE ARTIFACT test +go-lint/test AS LOCAL test
            +go-lint | *cached* --> SAVE ARTIFACT pkg +go-lint/pkg AS LOCAL pkg
            +go-lint | *cached* --> SAVE ARTIFACT internal +go-lint/internal AS LOCAL internal
            +go-lint | *cached* --> SAVE ARTIFACT cmd +go-lint/cmd AS LOCAL cmd
              output | --> exporting outputs
              output | [----------] 100% exporting outputs
              output | --> exporting outputs

 Push Summary ⏫ (disabled)
————————————————————————————————————————————————————————————————————————————————

To enable pushing use earthly --push

 Local Output Summary 🎁
————————————————————————————————————————————————————————————————————————————————

Artifact github.com/blakeromano/crossplane:helm-chart-topology-spread-constraints+go-generate/apis output as apis
Artifact github.com/blakeromano/crossplane:helm-chart-topology-spread-constraints+go-generate/crds output as cluster/crds
Artifact github.com/blakeromano/crossplane:helm-chart-topology-spread-constraints+go-lint/apis output as apis
Artifact github.com/blakeromano/crossplane:helm-chart-topology-spread-constraints+go-lint/cmd output as cmd
Artifact github.com/blakeromano/crossplane:helm-chart-topology-spread-constraints+go-lint/internal output as internal
Artifact github.com/blakeromano/crossplane:helm-chart-topology-spread-constraints+go-lint/pkg output as pkg
Artifact github.com/blakeromano/crossplane:helm-chart-topology-spread-constraints+go-lint/test output as test
Artifact github.com/blakeromano/crossplane:helm-chart-topology-spread-constraints+go-modules-tidy/go.mod output as go.mod
Artifact github.com/blakeromano/crossplane:helm-chart-topology-spread-constraints+go-modules-tidy/go.sum output as go.sum
Artifact github.com/blakeromano/crossplane:helm-chart-topology-spread-constraints+go-test/coverage.txt output as _output/tests/coverage.txt
Artifact github.com/blakeromano/crossplane:helm-chart-topology-spread-constraints+helm-generate/chart output as cluster/charts/crossplane


========================== 🌍 Earthly Build  ✅ SUCCESS ==========================

🛰️ Reuse cache between CI runs with Earthly Satellites! 2-20X faster than without cache. Generous free tier https://cloud.earthly.dev

[jbw976]

@blakeromano are you up for adding these values to the docs too?

• source: https://github.com/crossplane/docs/blob/master/content/master/software/install.md#customize-the-crossplane-helm-chart
• docs site URL: https://docs.crossplane.io/master/software/install/#customize-the-crossplane-helm-chart

I swear we used to have a process in the past to keep these automatically synced, but crossplane/docs#572 would beg to differ 😂

[blakeromano]

Created crossplane/docs#788