Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor ir_Kelvinator #1317

Merged
merged 8 commits into from
Nov 1, 2020
Merged

refactor ir_Kelvinator #1317

merged 8 commits into from
Nov 1, 2020

Conversation

siriuslzx
Copy link
Collaborator

No description provided.

crankyoldgit
crankyoldgit requested changes Oct 31, 2020
View reviewed changes
Copy link
Owner

@crankyoldgit crankyoldgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As usual, love your work. Looks good. Only a minor more aggressive suggestion for legacy clean-up. ;-)

src/ir_Kelvinator.cpp Outdated
Comment on lines 175 to 176
/// @param[in] length Deprecated
void IRKelvinatorAC::checksum(const uint16_t /*length*/) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this parameter is truly no longer used, rather than mark it Deprecated, just remove it.
IRKelvinatorAC::checksum() should be a private (vs. a public function) so we can do with it as we need, as no user is going to be able to call it.

src/ir_Kelvinator.h Outdated Show resolved Hide resolved
@crankyoldgit crankyoldgit added Hacktoberfest Hacktoberfest participation hacktoberfest-accepted Marking PRs as accepted for Hacktoberfest. labels Oct 31, 2020
@crankyoldgit
Copy link
Owner

TIP/FYI: You could probably git rebase rather that having to merge from the origin/master. It'd probably be cleaner. Not important. Just a FYI

@siriuslzx
Copy link
Collaborator Author

TIP/FYI: You could probably git rebase rather that having to merge from the origin/master. It'd probably be cleaner. Not important. Just a FYI

I accidentally made a mistake this time

crankyoldgit
crankyoldgit approved these changes Nov 1, 2020
View reviewed changes
Copy link
Owner

@crankyoldgit crankyoldgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Approved subject to that one thing. Update it, then merge away!

src/ir_Kelvinator.cpp Outdated Show resolved Hide resolved
@siriuslzx siriuslzx merged commit 9f19d55 into crankyoldgit:master Nov 1, 2020
crankyoldgit added a commit that referenced this pull request Nov 13, 2020
@crankyoldgit
v2.7.12 release
535b7e4 
_v2.7.12 (20201113)_

**[Bug Fixes]**
- `defaultBits()` returned incorrect result for `PANASONIC_AC` (#1307 #1314)
- Fix LG2 timings and refactor `decodeLG()` (#1298 #1304)

**[Features]**
- Midea: Add support for "Follow Me"/Sensor, Turbo, Light, & Timers (#1318 #1327)
- SharpAc: Add model support for A705 (#1309 #1313)
- Add basic support for Panasonic A/C 32bit/16bit protocol. (#1307 #1316)
- Add support for Elite Screens protocol. (#1306 #1310)
- IRrecvDumpV2+: Add tolerance setting. (#1292)
- Add basic support for the Mirage Protocol. (#1289 #1291)
- Internationalisation Support
  - pt-BR: Add Portuguese/Brazilian support. (#1303)
  - de-DE: Backfill missing strings (#1294)
  - de-DE: update for recent addition of 'tolerance' (#1293)
  - de-DE: Translate root README.md into German (#1297)

**[Misc]**
- refactor ir_LG (#1325)
- refactor ir_Kelvinator (#1317)
- refactor ir_Hitachi (#1308)
- refactor ir_Goodweather (#1295)
- refactor ir_Electra (#1290)
- refactor ir_Daikin (#1288)
- Update Kaysun supported models. (#1322)
- fix typos/spelling mistakes (#1301)
- Add some missing Doxygen class/data-type descriptions. (#1287)
@crankyoldgit crankyoldgit mentioned this pull request Nov 13, 2020
Merged
crankyoldgit added a commit that referenced this pull request Nov 13, 2020
@crankyoldgit
v2.7.12 release (#1330)
b7fa4ba 
_v2.7.12 (20201113)_

**[Bug Fixes]**
- `defaultBits()` returned incorrect result for `PANASONIC_AC` (#1307 #1314)
- Fix `LG2` timings and refactor `decodeLG()` (#1298 #1304)

**[Features]**
- Midea: Add support for "Follow Me"/Sensor, Turbo, Light, & Timers (#1318 #1327)
- SharpAc: Add model support for A705 (#1309 #1313)
- Add basic support for Panasonic A/C 32bit/16bit protocol. (#1307 #1316)
- Add support for Elite Screens protocol. (#1306 #1310)
- IRrecvDumpV2+: Add tolerance setting. (#1292)
- Add basic support for the Mirage Protocol. (#1289 #1291)
- Internationalisation Support
  - `pt-BR`: Add Portuguese/Brazilian support. (#1303)
  - `de-DE`: Backfill missing strings (#1294)
  - `de-DE`: update for recent addition of 'tolerance' (#1293)
  - `de-DE`: Translate root README.md into German (#1297)

**[Misc]**
- refactor ir_LG (#1325)
- refactor ir_Kelvinator (#1317)
- refactor ir_Hitachi (#1308)
- refactor ir_Goodweather (#1295)
- refactor ir_Electra (#1290)
- refactor ir_Daikin (#1288)
- Update Kaysun supported models. (#1322)
- fix typos/spelling mistakes (#1301)
- Add some missing Doxygen class/data-type descriptions. (#1287)
@crankyoldgit
Copy link
Owner

FYI, the changes mentioned above have now been included in the new v2.7.12 release of the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crankyoldgit crankyoldgit crankyoldgit approved these changes

Assignees

@siriuslzx siriuslzx

Labels
enhancement Hacktoberfest Hacktoberfest participation hacktoberfest-accepted Marking PRs as accepted for Hacktoberfest.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@siriuslzx @crankyoldgit