-
Notifications
You must be signed in to change notification settings - Fork 834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pt-BR locale #1303
Merged
crankyoldgit
merged 6 commits into
crankyoldgit:master
from
guieiras-dev:ft/ptBR-locale
Oct 17, 2020
Merged
Add pt-BR locale #1303
crankyoldgit
merged 6 commits into
crankyoldgit:master
from
guieiras-dev:ft/ptBR-locale
Oct 17, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* src/locale/pt-BR.h:167: #endif line should be "#endif // LOCALE_PT_BR_H_" [build/header_guard] [5]
Add easy support for PlatformIO to build the example with Brazilian Portuguese. This will also be used Travis CI build so it should pick up any errors.
... to fix a different linter error. Sigh.
crankyoldgit
added
enhancement
Hacktoberfest
Hacktoberfest participation
hacktoberfest-accepted
Marking PRs as accepted for Hacktoberfest.
labels
Oct 17, 2020
crankyoldgit
approved these changes
Oct 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many many thanks. Great first contribution to the library!
You've more than earned your 1/4 of a Hacktoberfest T-shirt here!
Awesome! It was a pleasure to colaborate. Thanks a lot. |
crankyoldgit
added a commit
that referenced
this pull request
Nov 13, 2020
_v2.7.12 (20201113)_ **[Bug Fixes]** - `defaultBits()` returned incorrect result for `PANASONIC_AC` (#1307 #1314) - Fix LG2 timings and refactor `decodeLG()` (#1298 #1304) **[Features]** - Midea: Add support for "Follow Me"/Sensor, Turbo, Light, & Timers (#1318 #1327) - SharpAc: Add model support for A705 (#1309 #1313) - Add basic support for Panasonic A/C 32bit/16bit protocol. (#1307 #1316) - Add support for Elite Screens protocol. (#1306 #1310) - IRrecvDumpV2+: Add tolerance setting. (#1292) - Add basic support for the Mirage Protocol. (#1289 #1291) - Internationalisation Support - pt-BR: Add Portuguese/Brazilian support. (#1303) - de-DE: Backfill missing strings (#1294) - de-DE: update for recent addition of 'tolerance' (#1293) - de-DE: Translate root README.md into German (#1297) **[Misc]** - refactor ir_LG (#1325) - refactor ir_Kelvinator (#1317) - refactor ir_Hitachi (#1308) - refactor ir_Goodweather (#1295) - refactor ir_Electra (#1290) - refactor ir_Daikin (#1288) - Update Kaysun supported models. (#1322) - fix typos/spelling mistakes (#1301) - Add some missing Doxygen class/data-type descriptions. (#1287)
Merged
crankyoldgit
added a commit
that referenced
this pull request
Nov 13, 2020
_v2.7.12 (20201113)_ **[Bug Fixes]** - `defaultBits()` returned incorrect result for `PANASONIC_AC` (#1307 #1314) - Fix `LG2` timings and refactor `decodeLG()` (#1298 #1304) **[Features]** - Midea: Add support for "Follow Me"/Sensor, Turbo, Light, & Timers (#1318 #1327) - SharpAc: Add model support for A705 (#1309 #1313) - Add basic support for Panasonic A/C 32bit/16bit protocol. (#1307 #1316) - Add support for Elite Screens protocol. (#1306 #1310) - IRrecvDumpV2+: Add tolerance setting. (#1292) - Add basic support for the Mirage Protocol. (#1289 #1291) - Internationalisation Support - `pt-BR`: Add Portuguese/Brazilian support. (#1303) - `de-DE`: Backfill missing strings (#1294) - `de-DE`: update for recent addition of 'tolerance' (#1293) - `de-DE`: Translate root README.md into German (#1297) **[Misc]** - refactor ir_LG (#1325) - refactor ir_Kelvinator (#1317) - refactor ir_Hitachi (#1308) - refactor ir_Goodweather (#1295) - refactor ir_Electra (#1290) - refactor ir_Daikin (#1288) - Update Kaysun supported models. (#1322) - fix typos/spelling mistakes (#1301) - Add some missing Doxygen class/data-type descriptions. (#1287)
FYI, the changes mentioned above have now been included in the new v2.7.12 release of the library. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
Hacktoberfest
Hacktoberfest participation
hacktoberfest-accepted
Marking PRs as accepted for Hacktoberfest.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've followed the instructions at src/locale/README.md, and here is my PR with pt-BR locale.
I did not find instructions on how to test it. So, if anything is broken, let me know and I will fix it as soon as possible.