Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configuration enhancement #24

Merged
merged 17 commits into from
Oct 5, 2016
Merged

Configuration enhancement #24

merged 17 commits into from
Oct 5, 2016

Commits on Oct 4, 2016

  1. Use == "" instead of len() == 0

    @tomsquest
    tomsquest committed Oct 4, 2016
    Configuration menu
    Copy the full SHA
    c2d8a81 View commit details
    Browse the repository at this point in the history

  2. Plug Cobra with Viper 

    By priority, variables come from:
* Cobra flags (command line) configure Viper
* Environment variables
* Config file
* Defaults
    @tomsquest
    tomsquest committed Oct 4, 2016
    Configuration menu
    Copy the full SHA
    e0b6475 View commit details
    Browse the repository at this point in the history

  3. Remove default config values, they are provided by cobra flags

    @tomsquest
    tomsquest committed Oct 4, 2016
    Configuration menu
    Copy the full SHA
    e32d87e View commit details
    Browse the repository at this point in the history

  4. Configure Viper for all commands

    @tomsquest
    tomsquest committed Oct 4, 2016
    Configuration menu
    Copy the full SHA
    b842fd3 View commit details
    Browse the repository at this point in the history

  5. Add config command to display the current Config 

    Output format is JSON
    @tomsquest
    tomsquest committed Oct 4, 2016
    Configuration menu
    Copy the full SHA
    741b49a View commit details
    Browse the repository at this point in the history

  6. Read port parameter 

    The param is a PersitentFlags and should be a local flag in `serve`
    @tomsquest
    tomsquest committed Oct 4, 2016
    Configuration menu
    Copy the full SHA
    cd9b5cd View commit details
    Browse the repository at this point in the history

  7. Bind Gin to configured port and set mode to release when specified

    @tomsquest
    tomsquest committed Oct 4, 2016
    Configuration menu
    Copy the full SHA
    febfa15 View commit details
    Browse the repository at this point in the history

  8. Use configured port when running status

    @tomsquest
    tomsquest committed Oct 4, 2016
    Configuration menu
    Copy the full SHA
    cfac0ce View commit details
    Browse the repository at this point in the history

  9. Add Address config param for the status and serve commands

    @tomsquest
    tomsquest committed Oct 4, 2016
    Configuration menu
    Copy the full SHA
    b099e12 View commit details
    Browse the repository at this point in the history

  10. Do not display the config if unable to marshall it

    @tomsquest
    tomsquest committed Oct 4, 2016
    Configuration menu
    Copy the full SHA
    e2d5edc View commit details
    Browse the repository at this point in the history

  11. Fix: read address from Viper

    @tomsquest
    tomsquest committed Oct 4, 2016
    Configuration menu
    Copy the full SHA
    51569bd View commit details
    Browse the repository at this point in the history

  12. Bind databaseUrl param

    @tomsquest
    tomsquest committed Oct 4, 2016
    Configuration menu
    Copy the full SHA
    f93825c View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2016

  1. Exit with error code 1 instead of -1 

    `-1` comes from Cobra docs...
    @tomsquest
    tomsquest committed Oct 5, 2016
    Configuration menu
    Copy the full SHA
    e8dcce0 View commit details
    Browse the repository at this point in the history

  2. Do not display usage on error running a command

    @tomsquest
    tomsquest committed Oct 5, 2016
    Configuration menu
    Copy the full SHA
    6b45213 View commit details
    Browse the repository at this point in the history

  3. Do not print the error manually, Cobra does it already

    @tomsquest
    tomsquest committed Oct 5, 2016
    Configuration menu
    Copy the full SHA
    e44ee35 View commit details
    Browse the repository at this point in the history

  4. Display the help/usage by default, when no command was given

    @tomsquest
    tomsquest committed Oct 5, 2016
    Configuration menu
    Copy the full SHA
    0a36737 View commit details
    Browse the repository at this point in the history

  5. Rename the command name from cozy to cozy-stack 

    The name is printed in the help:

BEFORE:
```
$ go run main.go error
Error: unknown command "error" for "cozy"
Run 'cozy --help' for usage.
exit status 1
```

After:
```
$ go run main.go error
Error: unknown command "error" for "cozy-stack"
Run 'cozy-stack --help' for usage.
exit status 1
```
    @tomsquest
    tomsquest committed Oct 5, 2016
    Configuration menu
    Copy the full SHA
    de9cf34 View commit details
    Browse the repository at this point in the history