Configuration enhancement #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By priority, variables come from: * Cobra flags (command line) configure Viper * Environment variables * Config file * Defaults
Output format is JSON
The param is a PersitentFlags and should be a local flag in `serve`
|
Great work, thanks @tomsquest ! I know this is not from your modifications, but I would also remove the error printing from the func main() {
if err := cmd.RootCmd.Execute(); err != nil {
fmt.Println(err) // <- redundant (and print in stdout...)
os.Exit(-1)
}
}Also the exit code should probably be 1 instead of -1 (255)... If you're OK with this little change, I'll happily merge your PR. |
`-1` comes from Cobra docs...
The name is printed in the help: BEFORE: ``` $ go run main.go error Error: unknown command "error" for "cozy" Run 'cozy --help' for usage. exit status 1 ``` After: ``` $ go run main.go error Error: unknown command "error" for "cozy-stack" Run 'cozy-stack --help' for usage. exit status 1 ```
|
@jinroh done + some more (see logs) |
|
Merged. Thanks @tomsquest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #21 "Configuration enhancement", see there for details