Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore "no such file or directory" error. #31

Merged
merged 1 commit into from
Oct 10, 2018

Conversation

Random-Liu
Copy link
Member

@codecov-io
Copy link

codecov-io commented Oct 10, 2018

Codecov Report

Merging #31 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #31   +/-   ##
=======================================
  Coverage   41.63%   41.63%           
=======================================
  Files           8        8           
  Lines         305      305           
=======================================
  Hits          127      127           
  Misses        148      148           
  Partials       30       30
Impacted Files Coverage Δ
cni.go 64.06% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7585e6d...a442970. Read the comment docs.

cni.go Show resolved Hide resolved
@Random-Liu
Copy link
Member Author

Sent containernetworking/plugins#213, if that gets merged we can remove the error handling after old CNI support is deprecated, but that still takes time.

@abhi abhi merged commit cc959f7 into containerd:master Oct 10, 2018
@Random-Liu Random-Liu deleted the ignore-not-exit-error branch October 10, 2018 18:18
@Random-Liu
Copy link
Member Author

Random-Liu commented Oct 10, 2018

@abhi Actually, I have a slightly better idea... :P Let me send out the change.

@abhi
Copy link
Member

abhi commented Oct 10, 2018

:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants