Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle empty namespace consistently #210

Closed
Random-Liu opened this issue Oct 10, 2018 · 3 comments
Closed

Handle empty namespace consistently #210

Random-Liu opened this issue Oct 10, 2018 · 3 comments

Comments

@Random-Liu
Copy link
Contributor

In #5, we decided to ignore empty network namespace.

However, this is not handled consistently across different network plugins:

  • Plugins that ignore empty namespace and don't return error: bridge, ptp, ipvlan, macvlan, vlan;
  • Plugins that return error if empty namespace is passed in: loopback, host-device.

Why don't we handle them consistently?

/cc @jingax10

@rosenhouse
Copy link
Contributor

What’s the use case for empty namespace?

@Random-Liu
Copy link
Contributor Author

It seems that there was some maintainer discussion before. #5

I think it is usually used when teardown network. Sometimes the network namespace is gone, but some resources are still not released, you need to run teardown to completely release all resources. For example, the ip checkpoint for host-local.

@Random-Liu
Copy link
Contributor Author

This is also defined in the new CNI spec containernetworking/cni@23a5d8e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants