Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused code from Legislation proposals #5140

Merged
merged 2 commits into from
Jun 27, 2023
Merged

Remove unused code from Legislation proposals #5140

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab2c548
Remove unused code for legislation proposals votes
taitus Jun 27, 2023
d2b1817
Call Legislation::Proposals::VotesComponent directly
taitus Jun 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Next Next commit
Remove unused code for legislation proposals votes 
In these commits 38ba5e1 and 8805037 we added the parameter
"vote_url" in the call to the partial "votes" in collaborative legislation
proposals.

It seems that this parameter is only used in the proposals module and not in
collaborative legislation proposals.

While it is true that in the partial "votes" in these commits this parameter
"vote_url" is referred to, in commit 276baed it seems to be removed.

For this reason, we remove the parameter.
  • Loading branch information
@taitus
taitus committed Jun 27, 2023
commit ab2c548964c057fb96b548a8480d0be032e5b583
3 changes: 1 addition & 2 deletions app/views/legislation/proposals/_proposal.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,7 @@
</div>

<div id="<%= dom_id(proposal) %>_votes" class="small-12 medium-3 column">
<%= render "legislation/proposals/votes",
{ proposal: proposal, vote_url: vote_legislation_process_proposal_path(proposal.legislation_process_id, proposal, value: "yes") } %>
<%= render "legislation/proposals/votes", proposal: proposal %>
</div>
</div>
</div>
Expand Down
3 changes: 1 addition & 2 deletions app/views/legislation/proposals/show.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,7 @@
<div class="sidebar-divider"></div>
<h2><%= t("votes.supports") %></h2>
<div id="<%= dom_id(@proposal) %>_votes">
<%= render "votes",
{ proposal: @proposal, vote_url: vote_legislation_process_proposal_path(@proposal.legislation_process_id, @proposal, value: "yes") } %>
<%= render "votes", proposal: @proposal %>
</div>
<%= render "shared/social_share",
share_title: t("proposals.show.share"),
Expand Down