Remove unused code from Legislation proposals #5140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In these commits 38ba5e1 and 8805037 we added the parameter "vote_url" in the call to the partial "votes" in collaborative legislation proposals. It seems that this parameter is only used in the proposals module and not in collaborative legislation proposals. While it is true that in the partial "votes" in these commits this parameter "vote_url" is referred to, in commit 276baed it seems to be removed. For this reason, we remove the parameter.
taitus
force-pushed
the
legislation-proposals
branch
from
719124f
to
d2b1817
Compare
javierm
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Related PR: #1906
Objectives
Remove unused code.
Description
In these commits 38ba5e1 and 8805037 we added the parameter "vote_url" in the call to the partial "votes" in collaborative legislation proposals.
It seems that this parameter is only used in the proposals module and not in collaborative legislation proposals.
While it is true that in the partial "votes" in these commits this parameter "vote_url" is referred to, in commit 276baed it seems to be removed.