Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spec #5117

Merged
merged 1 commit into from
May 24, 2023
Merged

Update spec #5117

merged 1 commit into from
May 24, 2023

Conversation

taitus
Copy link
Member

@taitus taitus commented May 24, 2023

References

Related PR: #5113
Related commit: b9da024

Objectives

In order to prevent "flaky specs" we configure the database before starting the browser with a call to visit

@javierm javierm added this to Reviewing in Consul Democracy May 24, 2023
Copy link
Member

@Senen Senen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! I did not noticed that the test was calling the database after the visit 🙏🏼

Consul Democracy automation moved this from Reviewing to Testing May 24, 2023
@taitus
Copy link
Member Author

taitus commented May 24, 2023

Nice catch! I did not noticed that the test was calling the database after the visit 🙏🏼

@Senen I didn't notice it either

Configure the database before starting the browser with a call to `visit`
@taitus taitus merged commit d655acc into master May 24, 2023
9 checks passed
Consul Democracy automation moved this from Testing to Release 2.0.0 May 24, 2023
@taitus taitus deleted the update-spec branch May 24, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants