Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show email digest only if proposals are enabled #5113

Merged
merged 1 commit into from
May 23, 2023

Conversation

decabeza
Copy link
Collaborator

Objectives

Users can select the option "Receive a summary of proposal notifications" on the My Account /account page.

These notifications are created by proposal authors for users who have supported the proposal.

To avoid confusion and improve the UX, this PR hides that checkbox if the proposals feature is disabled, as it doesn't make sense to show the option if those notifications cannot be created. 😌

Visual Changes

proposals_notifications

@decabeza decabeza self-assigned this May 19, 2023
@javierm javierm added this to Reviewing in Consul Democracy May 19, 2023
Consul Democracy automation moved this from Reviewing to Testing May 22, 2023
Copy link
Member

@Senen Senen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! 👏🏼

@Senen Senen merged commit c52d287 into master May 23, 2023
Consul Democracy automation moved this from Testing to Release 2.0.0 May 23, 2023
@Senen Senen deleted the proposals_notifications branch May 23, 2023 09:35
@taitus taitus mentioned this pull request May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants