Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement or remove pending tests #4803

Merged
merged 20 commits into from
Apr 7, 2022
Merged

Implement or remove pending tests #4803

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
b89c358
Remove comments related to code from Madrid
javierm Sep 6, 2021
1f55be7
Remove obsolete pending test reference
javierm Sep 6, 2021
3752fef
Remove map page in debates
javierm Sep 6, 2021
c777594
Enable poll comments test
javierm Sep 6, 2021
0eb666d
Allow commenting on polls as moderator/admin
javierm Sep 6, 2021
42b8729
Remove duplicate map test
javierm Sep 6, 2021
d5867db
Remove unnecessary condition to skip tag list test
javierm Sep 6, 2021
fa15ac0
Implement pending email digest test
javierm Sep 7, 2021
6ddb22c
Enable test checking alert to finish valuation
javierm Sep 7, 2021
695d5d8
Enable passing legislation comment test
javierm Sep 7, 2021
6c322e2
Implement tests to disable homepage settings
javierm Sep 7, 2021
4a8a4ea
Remove pending tag cloud test for debates
javierm Sep 7, 2021
c579127
Implement pending card image expectations
javierm Sep 7, 2021
702fc84
Remove pending reportable tests
javierm Sep 8, 2021
2927174
Remove unnecessary locales check in specs
javierm Sep 8, 2021
e49c326
Use `if` instead of `skip` to skip tests
javierm Sep 8, 2021
c0f71c4
Complete proposal notification test
javierm Apr 4, 2022
fb99d8c
Remove obsolete "pending" test
javierm Apr 4, 2022
e637bce
Fix error messages for question answer images
javierm Apr 4, 2022
b68aa67
Remove unnecessary "pending" comment
javierm Apr 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove obsolete "pending" test 
I'd say this feature is actually tested in the "proposal polls specific
validations"; the empty test was probably added by accident in commit
4b8cc85.
  • Loading branch information
@javierm
javierm committed Apr 7, 2022
commit fb99d8cb33da6e7ba3c655b9aa4960cc1a2a58a6
2 changes: 0 additions & 2 deletions spec/models/poll/poll_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,6 @@
poll.ends_at = 2.months.ago
expect(poll).not_to be_valid
end

pending "no overlapping polls for proposal polls are allowed"
end

describe "proposal polls specific validations" do
Expand Down