Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement or remove pending tests #4803

Merged
merged 20 commits into from
Apr 7, 2022
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove unnecessary condition to skip tag list test
This file only has tests related to tags; if the model doesn't have
tags, we simply wouldn't include `it_behaves_as` in their tests instead
of including it and then skipping it.
  • Loading branch information
javierm committed Apr 7, 2022
commit d5867db2cf7e6c4ef6397499d03415a999d3f696
6 changes: 0 additions & 6 deletions spec/shared/models/sanitizable.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,6 @@
let(:sanitizable) { build(model_name(described_class)) }

describe "#tag_list" do
before do
unless described_class.included_modules.include?(Taggable)
skip "#{described_class} does not have a tag list"
end
end

it "sanitizes the tag list" do
sanitizable.tag_list = "user_id=1"

Expand Down