Remove Capybara default_set_options for non JS system tests
#4542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Test driver The next warning is flooding the tests log: `Options passed to Node#set but the RackTest driver doesn't support any - ignoring` As the rack test driver does not support any option, we get rid of all `default_set_options` before each system spec that uses this driver.
Senen
force-pushed
the
rack_test_driver_warning
branch
from
bf79ec4
to
7a33314
Compare
javierm
approved these changes
Jun 10, 2021
There was a problem hiding this comment.
Awesome!
Funny how I tested this approach while working on pull request #4456 and discarded it because I got an "unknown option" error.
Who knows, maybe when testing it I wrote clear: backpsace or something 😅.
Seems to be working fine 👍.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Background
The next warning is flooding the tests log:
Options passed to Node#set but the RackTest driver doesn't support any - ignoringAs the rack test driver does not support any option for the Node#set method, we get rid of all
default_set_optionsbefore each system spec that uses this driver.From Capybara's docs:
default_set_options (Hash = {}) - The default options passed to Element#set.Objectives
Do not pass options to rack test driver to get rid of the warning.