Clear fields in tests before filling them in #4456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierm
force-pushed
the
browser_tests
branch
2 times, most recently
from
07bc106
to
8c46110
Compare
javierm
force-pushed
the
clear_backspace
branch
2 times, most recently
from
740246d
to
a5dd247
Compare
javierm
force-pushed
the
browser_tests
branch
4 times, most recently
from
2b123b5
to
5f5ef3e
Compare
There seems to be an issue with capybara or chromedriver which results in `fill_in` sometimes appending to an input rather than overwriting [1], causing some tests to fail under certain circumstances. Clearing fields before filling them in solves the issue. Note we're now getting warnings on all tests using the rack driver. I haven't found a way to avoid the `clear: :backspace` option in non-JavaScript tests, so to avoid the annoying warnings we should reduce the number of tests using the rack driver even more. [1] See issue 2419 in https://github.com/teamcapybara/capybara/issues
Even after the previous changes, this test is still failing sometimes (although now it fails for a different reason). We're doing this change in order to discard it as the reason why the test is failing.
taitus
approved these changes
Apr 12, 2021
javierm
force-pushed
the
clear_backspace
branch
from
de2b7db
to
235e396
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Background
There seems to be an issue with capybara or chromedriver which results in
fill_insometimes appending to an input rather than overwriting, causing some tests to fail under certain circumstances.Objectives
Notes
We're getting warnings on all tests using the rack driver. I haven't found a way to avoid the
clear: :backspaceoption in non-JavaScript tests, so to avoid the annoying warnings we should reduce the number of tests using the rack driver even more.