Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Harmony mode in uglifier for ES2015+ support #4192

Merged
merged 1 commit into from
Oct 2, 2020
Merged

Use Harmony mode in uglifier for ES2015+ support #4192

merged 1 commit into from
Oct 2, 2020

Conversation

javierm
Copy link
Member

@javierm javierm commented Oct 2, 2020 •
edited

References

Objectives

Make it possible to compile the assets included in graphql-rails with Uglifier on production environments.

@javierm javierm added the Bug label Oct 2, 2020
@javierm javierm self-assigned this Oct 2, 2020
@javierm javierm added this to Reviewing in Consul Democracy via automation Oct 2, 2020
@javierm
Use Harmony mode in uglifier for ES2015+ support
4bb1b3a 
Recent versions of graphql-rails updated React to a version which
requires this mode so it can be compiled on production.

So we enable this mode is described in the Uglifier README [2].

[1] https://github.com/lautis/uglifier/tree/v4.2.0#es6--es2015--harmony-mode
Consul Democracy automation moved this from Reviewing to Testing Oct 2, 2020
Senen
Senen approved these changes Oct 2, 2020
View reviewed changes
Copy link
Member

@Senen Senen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to reproduce the error trying to deploy master branch to a production environment then i deployed successfully the harmony branch! 👍

@javierm javierm merged commit afeb071 into master Oct 2, 2020
Consul Democracy automation moved this from Testing to Release 1.3.0 Oct 2, 2020
@javierm javierm deleted the harmony branch October 2, 2020 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Senen Senen Senen approved these changes

Assignees

@javierm javierm

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@javierm @Senen