Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onEditQuery is undefined #70

Closed
raysuelzer opened this issue Aug 22, 2019 · 1 comment · Fixed by #83
Closed

onEditQuery is undefined #70

raysuelzer opened this issue Aug 22, 2019 · 1 comment · Fixed by #83

Comments

@raysuelzer
Copy link

There is an error in the javascript when config.query_params is set to true that causes the interface to not load.

This line references onEditQuery which is not defined because the definition occurs within a different function scope.

queryParams = Object.assign({}, queryParams, { query: parameters.query, variables: parameters.variables, onEditQuery: onEditQuery, onEditVariables: onEditVariables });

image

@duffyjp
Copy link

duffyjp commented Dec 30, 2019

I got that when I did a deploy to production. Quite the surprize.

Tasks: TOP => assets:precompile
(See full trace by running task with --trace)


Caused by:
SSHKit::Command::Failed: rake exit status: 1
rake aborted!
Uglifier::Error: In strict mode code, functions can only be declared at top level or immediately within another function.
--
 49819           JSON.stringify(JSON.parse(parameters.variables), null, 2);
 49820       } catch (e) {
 49821         // Do nothing, we want to display the invalid JSON as a string, rather
 49822         // than present an error.
 49823       }
 49824     }
 49825     // When the query and variables string is edited, update the URL bar so
 49826     // that it can be easily shared
    =>     function onEditQuery(newQuery) {
 49828       parameters.query = newQuery;
 49829       updateURL();
 49830     }
 49831     function onEditVariables(newVariables) {
 49832       parameters.variables = newVariables;
 49833       updateURL();
 49834     }
 49835     function updateURL() {
==

There is an old closed issue, #44 with a workaround I can confirm does NOT work. It will deploy, but have a JS error and break your whole site.

Screen Shot 2019-12-30 at 9 05 47 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants