Fix Infinity exceptions in hot score calculator #3678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierm
force-pushed
the
fix_nan_score
branch
from
1769161
to
fb352f7
Compare
houndci-bot
reviewed
Sep 5, 2019
javierm
force-pushed
the
capybara_webmock
branch
4 times, most recently
from
a784261
to
8bb5462
Compare
javierm
force-pushed
the
fix_nan_score
branch
from
fb352f7
to
7061e61
Compare
javierm
force-pushed
the
fix_nan_score
branch
from
7061e61
to
2626d7b
Compare
There was a rare case we've found on some Travis builds where the system time suddenly moved back to the past a couple of tenths of a second, meaning `Time.current - resource.created_at` returned a negative number, which lead to a division by zero.
javierm
force-pushed
the
fix_nan_score
branch
from
2626d7b
to
53abc57
Compare
|
Travis failure is not related to this pull request. |
smarques
pushed a commit
to venetochevogliamo/consul
that referenced
this pull request
Apr 29, 2020
Fix Infinity exceptions in hot score calculator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Objectives
Fix a rare case we've found on some Travis builds where the system time suddenly moved back to the past a couple of tenths of a second, meaning
Time.current - resource.created_atreturned a negative number, which lead to a division by zero.