Merge pull request #3678 from consul/fix_nan_score

Fix Infinity exceptions in hot score calculator

lib/score_calculator.rb

@@ -3,10 +3,7 @@ module ScoreCalculator
  def self.hot_score(resource)
  return 0 unless resource.created_at
 
- period = [
- Setting["hot_score_period_in_days"].to_i,
- ((Time.current - resource.created_at) / 1.day).ceil
- ].min
+ period = [1, [max_period, resource_age(resource)].min].max
 
  votes_total = resource.votes_for.where("created_at >= ?", period.days.ago).count
  votes_up = resource.get_upvotes.where("created_at >= ?", period.days.ago).count
@@ -27,4 +24,12 @@ def self.confidence_score(votes_total, votes_up)
  score * (votes_up / votes_total) * 100
  end
 
+ def self.max_period
+ Setting["hot_score_period_in_days"].to_i
+ end
+
+ def self.resource_age(resource)
+ ((Time.current - resource.created_at) / 1.day).ceil
+ end
+
 end

spec/lib/score_calculator_spec.rb

@@ -0,0 +1,29 @@
+require "rails_helper"
+
+describe ScoreCalculator do
+ describe ".hot_score" do
+ let(:resource) { create(:debate) }
+
+ before do
+ resource.vote_by(voter: create(:user), vote: "yes")
+ end
+
+ it "ignores small time leaps", :with_frozen_time do
+ resource.created_at = Time.current + 0.01
+
+ expect(ScoreCalculator.hot_score(resource)).to eq 1
+ end
+
+ it "ignores setting with negative value " do
+ Setting["hot_score_period_in_days"] = -1
+
+ expect(ScoreCalculator.hot_score(resource)).to eq 1
+ end
+
+ it "ignores setting with zero value" do
+ Setting["hot_score_period_in_days"] = 0
+
+ expect(ScoreCalculator.hot_score(resource)).to eq 1
+ end
+ end
+end