Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport] Fix literal as condition #3313

Merged
merged 2 commits into from
Feb 18, 2019
Merged

[Backport] Fix literal as condition #3313

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
250b19b
Remove literal used in condition
javierm Dec 18, 2018
e11b9dd
Enable literal as condition rule in rubocop
javierm Dec 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Enable literal as condition rule in rubocop 
This way deverlopers who don't run the ruby syntax check locally with
warnings enabled will be informed by HoundCI.
  • Loading branch information
@javierm
javierm committed Feb 15, 2019
commit e11b9ddccd6adaf25a1dbcb380105f02b72479f2
3 changes: 3 additions & 0 deletions .rubocop_basic.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,9 @@ Layout/TrailingBlankLines:
Layout/TrailingWhitespace:
Enabled: true

Lint/LiteralAsCondition:
Enabled: true

Lint/UselessAssignment:
Enabled: true

Expand Down