Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport] Fix literal as condition #3313

Merged
merged 2 commits into from
Feb 18, 2019
Merged

[Backport] Fix literal as condition #3313

merged 2 commits into from
Feb 18, 2019

Commits on Feb 15, 2019

  1. Remove literal used in condition 

    The right syntax would have been:

`after_save :recalculate_heading_winners, if: :incompatible_changed?`

However, since the method `recalculate_heading_winners` already executes
the `if incompatible_changed?` condition, removing it keeps the intended
behaviour.
    @javierm
    javierm committed Feb 15, 2019
    Configuration menu
    Copy the full SHA
    250b19b View commit details
    Browse the repository at this point in the history

  2. Enable literal as condition rule in rubocop 

    This way deverlopers who don't run the ruby syntax check locally with
warnings enabled will be informed by HoundCI.
    @javierm
    javierm committed Feb 15, 2019
    Configuration menu
    Copy the full SHA
    e11b9dd View commit details
    Browse the repository at this point in the history