feat(commit): use OS-specific cache dir for commitizen.json instead of home-or-tmp

[malept]

This is a continuation of #252. I would have used the existing commits in that PR, but the branch was no longer available.

Since I added fs-extra for the ensureDir function, I also replaced rimraf usage with the equivalent fs-extra functionality.

Fixes #240, #339.
Closes #252.

TODO

• Use a release of cachedir that has Windows support

[malept]

Sigh. I forgot that env-paths doesn't work with Node < 4.

[LinusU]

I have merged your PR to node-cachedir, you can depend on ^1.1.0 now :)

[LinusU]

Nice 👌

[LinusU]

Any idea about the test failure?

[malept]

Not particularly. It runs fine locally (otherwise I wouldn't be able to commit). I think it has something to do with how the CI is set up, because it looks like AppVeyor has one error and Travis has another.

[jimthedev]

I'll look into CI.

[jimthedev]

Still looking into this but this is what I get when I run npm install && npm test locally on your fork.

> [email protected] test /Users/jim.cummins/projects/cz-forks/cz-cli
> nyc --require babel-core/register _mocha -- test/tests/index.js



  adapter
    1) resolves adapter paths
    2) gets adapter prompter functions

  git-cz
    bootstrap
      when config is provided
        ✓ passes config to useGitCzStrategy
      when config is not provided
        and the config is returned from configLoader.load
          ✓ uses config from configLoader.load()
        and the config is not returned from configLoader.load
          ✓ tells commitizen to use the git strategy

  commit
    3) should commit simple messages
    4) should commit message with quotes
    5) should commit multiline messages
    6) should allow to override git commit options

  configLoader
    ✓ errors appropriately for invalid json
    ✓ parses json files with comments
    ✓ normalizes package.json configs
    ✓ normalizes .cz.json configs
    ✓ normalizes .czrc configs

  init
    7) installs an adapter with --save-dev
    8) installs an adapter with --save
    9) errors on previously installed adapter
    10) succeeds if force is true
    11) installs an adapter without --save-exact
    12) installs an adapter with --save-exact

  staging
    ✓ should determine if a repo is clean (5853ms)

  common util
    ✓ isArray determines if array is passed
    ✓ isFunction determines if a function is passed
    ✓ isString determines if string is passed


  12 passing (6m)
  12 failing

  1) adapter resolves adapter paths:
     Error: the string "A previous adapter is already configured. Use --force to override" was thrown, throw an Error :)


  2) adapter gets adapter prompter functions:
     Error: the string "A previous adapter is already configured. Use --force to override" was thrown, throw an Error :)


  3) commit should commit simple messages:
     Error: the string "A previous adapter is already configured. Use --force to override" was thrown, throw an Error :)


  4) commit should commit message with quotes:
     Error: the string "A previous adapter is already configured. Use --force to override" was thrown, throw an Error :)


  5) commit should commit multiline messages:
     Error: the string "A previous adapter is already configured. Use --force to override" was thrown, throw an Error :)


  6) commit should allow to override git commit options:
     Error: the string "A previous adapter is already configured. Use --force to override" was thrown, throw an Error :)


  7) init installs an adapter with --save-dev:
     Error: the string "A previous adapter is already configured. Use --force to override" was thrown, throw an Error :)


  8) init installs an adapter with --save:
     Error: the string "A previous adapter is already configured. Use --force to override" was thrown, throw an Error :)


  9) init errors on previously installed adapter:
     Error: the string "A previous adapter is already configured. Use --force to override" was thrown, throw an Error :)


  10) init succeeds if force is true:
     Error: the string "A previous adapter is already configured. Use --force to override" was thrown, throw an Error :)


  11) init installs an adapter without --save-exact:
     Error: the string "A previous adapter is already configured. Use --force to override" was thrown, throw an Error :)


  12) init installs an adapter with --save-exact:
     Error: the string "A previous adapter is already configured. Use --force to override" was thrown, throw an Error :)

[malept]

Strange. I just checked out my branch on a machine that has never had commitizen installed on it, ran npm install && npm test, and all tests pass.

[jimthedev]

@malept I wonder if it has to do with the fact that I have a commitizen adapter installed globally so that I can use the cli in directories that don't have an adapter initialized.

[malept]

That would explain the error you're getting.

[jimthedev]

Yeah renaming my ~/.czrc file made it so that all tests pass locally. Working on CI still.

[jimthedev]

I have a branch where I am working on CI errors. We were not reporting git log errors in test.

[jimthedev]

Here are the actual errors we're getting.
https://travis-ci.org/commitizen/cz-cli/jobs/183566039

Looking at our builds, this was introduced earlier so it is not specifically due to this PR. Could be a git config change on Travis that we didn't catch. Either way you can track this on #401.

[jimthedev]

@malept I just pushed a fix for CI to master so if you merge master into your branch you should get those CI changes and your tests should pass.

[malept]

@jimthedev thanks for the heads up, I will rebase/squash later tonight.

[jimthedev]

Looks good. Our appveyor tests are failing just due to how long they run but travis seems happy.

[jimthedev]

Closes #339 as well.