-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(commit): moved cache (#240) #252
Conversation
Moved the cache from the home folder to a designated config folder
@@ -1,5 +1,5 @@ | |||
import path from 'path'; | |||
import homeOrTmp from 'home-or-tmp'; | |||
import ConfigDir from 'application-config-path'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that the convention is that initial uppercase letter is for classes, can you change this name to configDir
instead? thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Certainly, hang on :)
Fixed the casing of ConfigDir to match guidelines
👍 I'll look into the failing build when I'm not at work |
I'm pulling my hairs out over this one, I literally replaced a string with another string ?_? |
I'm going to give that a try |
Create the cache directory if it doesn't exist yet.
@dealloc Maybe it's better to use this package since it's actually meant for cache? The current one is meant for config which isn't really what this is... |
does this also handle creating the directories etc? or would I need to handle that myself? EDIT: a quick skim gives me the impression this more or less does the same as the package you suggested before (generate OS specific strings) but it seems that this package will throw on Windows, which is probably not really what we want |
This works the same, it will just give back the path. Ahh, you're right, we should probably fix that first. PR welcome if you have the time, otherwise I'll try and fix it as soon as possible. |
I suggest for now we could just use the package I already included and just update it when the other one is fixed. The main thing right now is that it won't commit and I have no clue why (I suspect #205 is the culprit here). |
…f home-or-tmp Based on commitizen#252. Fixes commitizen#240, commitizen#252, commitizen#339
…f home-or-tmp Based on commitizen#252. Fixes commitizen#240, commitizen#252, commitizen#339
Moved the cache from the home folder to a designated config folder
This fixes #240 by moving the commitizen.json cache file out of the home folder